-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] 3D viewers integration #1259
[FEATURE] 3D viewers integration #1259
Conversation
markusweigelt
commented
Jun 12, 2024
- Add middleware for embedding installed 3D viewers via iframe
- Adjust current implementation and remove unnecessary files
- Implement error handling to account for multiple scenarios
- Documentation (Setup, configuration and creating custom viewers)
- Bugfixes of NPE and loading METS/MODS documents
I like the improved documentation and more robust integration via middleware, but I think we should provide a default configuration which works out-of-the-box. So, there should be at least one default viewer pre-configured and all necessary files bundled with Kitodo.Presentation. I'd prefer three.js as default, but that's up to you! Also, the default in documentation and configuration should be for all viewers to host their components (third-party libraries, configs, styles, etc.) locally with Kitodo.Presentation, because there are multiple users which run Kitodo in a controlled environment without access to the internet. |
No problem, we can provide a default implementation, but we should discuss the default viewer. That's why I think the model-viewer (based on
All our current viewer implementations at https://github.com/slub/dlf-3d-viewers can run locally. Otherwise, I believe it is the responsibility of our implementation repository and not part of this PR. Only the If I misunderstood anything, we can certainly discuss it further to clarify. :) |
Perfect! Then let's use the model-viewer as a default. Since glTF/GLB is the most common 3D format, I think it's reasonable to only support those with our default configuration.
What I meant is, that all files should be hosted on the Kitodo server and not loaded from their original source or some kind of CDN. The Kompakkt viewer is special, because AFAIK it's the only viewer which needs its own server-side backend. |
This is taken into account with the implementation repository. There is an installation script that downloads the respective resources and adds them to the viewer as a module folder. |
Please add the default viewer to the source code (in its own sub-directory of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!